brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

St: don't focus hidden actors

Browse Source 
If an actors is not mapped (visible and all parents visible), then don't
allow navigating focus to it.
This fixes a regression in the keyboard navigation of the panel with
invisibile items.

https://bugzilla.gnome.org/show_bug.cgi?id=683529
This commit is contained in:
Giovanni Campagna
2012-09-06 22:12:44 +02:00
parent 452ac297ab
commit 09e3aed770
4 changed files with 32 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
src/st/st-widget.c
View File

@ -763,18 +763,7 @@ st_widget_get_paint_volume (ClutterActor *self,
static GList *
st_widget_real_get_focus_chain (StWidget *widget)
{
ClutterActorIter iter;
ClutterActor *child;
GList *focus_chain = NULL;
clutter_actor_iter_init (&iter, CLUTTER_ACTOR (widget));
while (clutter_actor_iter_next (&iter, &child))
{
if (CLUTTER_ACTOR_IS_VISIBLE (child))
focus_chain = g_list_prepend (focus_chain, child);
}
return g_list_reverse (focus_chain);
return clutter_actor_get_children (CLUTTER_ACTOR (widget));
}
@ -1898,9 +1887,17 @@ st_widget_real_navigate_focus (StWidget *widget,
{
if (!focus_child)
{
/* Accept focus from outside */
clutter_actor_grab_key_focus (widget_actor);
return TRUE;
if (CLUTTER_ACTOR_IS_MAPPED (widget_actor))
{
/* Accept focus from outside */
clutter_actor_grab_key_focus (widget_actor);
return TRUE;
}
else
{
/* Refuse to set focus on hidden actors */
return FALSE;
}
}
else
{