brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

shell/window-preview: Make window-container construct-only

Browse Source 
It is tightly coupled to the preview, and not meant to be unset
or replaced during the lifetime of the object; size requests
and allocation assume that it exists.

Make that explicit by marking the property as construct-only.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3615>
This commit is contained in:
Florian Müllner
2025-01-23 04:45:04 +01:00
committed by Marge Bot
parent 0f9c13c55d
commit 094caeeeef
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/shell-window-preview.c
View File

@@ -53,8 +53,7 @@ shell_window_preview_set_property (GObject *gobject,
switch (property_id) switch (property_id)
{ {
case PROP_WINDOW_CONTAINER: case PROP_WINDOW_CONTAINER:
if (g_set_object (&self->window_container, g_value_get_object (value))) g_set_object (&self->window_container, g_value_get_object (value));
g_object_notify_by_pspec (gobject, obj_props[PROP_WINDOW_CONTAINER]);
break; break;
default: default:
@@ -168,7 +167,7 @@ shell_window_preview_class_init (ShellWindowPreviewClass *klass)
g_param_spec_object ("window-container", NULL, NULL, g_param_spec_object ("window-container", NULL, NULL,
CLUTTER_TYPE_ACTOR, CLUTTER_TYPE_ACTOR,
G_PARAM_READWRITE | G_PARAM_READWRITE |
G_PARAM_EXPLICIT_NOTIFY | G_PARAM_CONSTRUCT_ONLY |
G_PARAM_STATIC_STRINGS); G_PARAM_STATIC_STRINGS);
g_object_class_install_properties (gobject_class, PROP_LAST, obj_props); g_object_class_install_properties (gobject_class, PROP_LAST, obj_props);