From 092338a4c73fda1f2f3533a3f1ac8a570e8599f8 Mon Sep 17 00:00:00 2001 From: Dan Winship Date: Thu, 8 Sep 2011 13:11:39 -0400 Subject: [PATCH] keyboard: hide the keyboard when unfocusing a shell entry Previously we explicitly didn't do this, although I can't figure out why now... definitely seems to work more smoothly this way. https://bugzilla.gnome.org/show_bug.cgi?id=658591 --- js/ui/keyboard.js | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/js/ui/keyboard.js b/js/ui/keyboard.js index e759a76f7..46a45b55b 100644 --- a/js/ui/keyboard.js +++ b/js/ui/keyboard.js @@ -265,15 +265,14 @@ Keyboard.prototype = { _onKeyFocusChanged: function () { let focus = global.stage.key_focus; - if (focus == global.stage || focus == null) + // Showing an extended key popup will grab focus, but ignore that + if (focus && focus._extended_keys) return; if (focus instanceof Clutter.Text) this.show(); - else { - if (focus._extended_keys == null) - this.hide(); - } + else + this.hide(); }, _addKeys: function () {