From 091fb4ba2e86c22a4469a62ddf8f87df16187e54 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Tue, 13 Jun 2017 06:49:07 +0200 Subject: [PATCH] Don't use 'undefined' as boolean Make sure we pass a proper false value instead of undefined to avoid warnings. https://bugzilla.gnome.org/show_bug.cgi?id=781471 --- js/ui/keyboard.js | 2 +- js/ui/notificationDaemon.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/js/ui/keyboard.js b/js/ui/keyboard.js index 4af1f1a75..6c43888db 100644 --- a/js/ui/keyboard.js +++ b/js/ui/keyboard.js @@ -570,7 +570,7 @@ const Keyboard = new Lang.Class({ shouldTakeEvent: function(event) { let actor = event.get_source(); return Main.layoutManager.keyboardBox.contains(actor) || - actor._extended_keys || actor.extended_key; + !!actor._extended_keys || !!actor.extended_key; }, _clearKeyboardRestTimer: function() { diff --git a/js/ui/notificationDaemon.js b/js/ui/notificationDaemon.js index 62096258d..315bfdb17 100644 --- a/js/ui/notificationDaemon.js +++ b/js/ui/notificationDaemon.js @@ -391,10 +391,10 @@ const FdoNotificationDaemon = new Lang.Class({ notification.setUrgency(MessageTray.Urgency.CRITICAL); break; } - notification.setResident(hints.resident == true); + notification.setResident(!!hints.resident); // 'transient' is a reserved keyword in JS, so we have to retrieve the value // of the 'transient' hint with hints['transient'] rather than hints.transient - notification.setTransient(hints['transient'] == true); + notification.setTransient(!!hints['transient']); let sourceGIcon = source.useNotificationIcon ? gicon : null; source.processNotification(notification, sourceGIcon);