brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

windowManager: Remove 'animate' parameter from (un)dimWindow()

Browse Source 
The parameter has become rather pointless since we always pass the
same value.

https://bugzilla.gnome.org/show_bug.cgi?id=674499
This commit is contained in:
Florian Müllner 2012-07-14 01:37:10 +02:00
parent 6ab25cd791
commit 04570ac783
1 changed files with 16 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
js/ui/windowManager.js
View File

@ -145,11 +145,11 @@ const WindowManager = new Lang.Class({
Main.overview.connect('showing', Lang.bind(this, function() { Main.overview.connect('showing', Lang.bind(this, function() {
for (let i = 0; i < this._dimmedWindows.length; i++) for (let i = 0; i < this._dimmedWindows.length; i++)
this._undimWindow(this._dimmedWindows[i], true); this._undimWindow(this._dimmedWindows[i]);
})); }));
Main.overview.connect('hiding', Lang.bind(this, function() { Main.overview.connect('hiding', Lang.bind(this, function() {
for (let i = 0; i < this._dimmedWindows.length; i++) for (let i = 0; i < this._dimmedWindows.length; i++)
this._dimWindow(this._dimmedWindows[i], true); this._dimWindow(this._dimmedWindows[i]);
})); }));
}, },
@ -265,43 +265,37 @@ const WindowManager = new Lang.Class({
window._dimmed = true; window._dimmed = true;
this._dimmedWindows.push(window); this._dimmedWindows.push(window);
if (!Main.overview.visible) if (!Main.overview.visible)
this._dimWindow(window, true); this._dimWindow(window);
} else if (!shouldDim && window._dimmed) { } else if (!shouldDim && window._dimmed) {
window._dimmed = false; window._dimmed = false;
this._dimmedWindows = this._dimmedWindows.filter(function(win) { this._dimmedWindows = this._dimmedWindows.filter(function(win) {
return win != window; return win != window;
}); });
if (!Main.overview.visible) if (!Main.overview.visible)
this._undimWindow(window, true); this._undimWindow(window);
} }
}, },
_dimWindow: function(window, animate) { _dimWindow: function(window) {
let actor = window.get_compositor_private(); let actor = window.get_compositor_private();
if (!actor) if (!actor)
return; return;
if (animate) Tweener.addTween(getWindowDimmer(actor),
Tweener.addTween(getWindowDimmer(actor), { dimFraction: 1.0,
{ dimFraction: 1.0, time: DIM_TIME,
time: DIM_TIME, transition: 'linear'
transition: 'linear' });
});
else
getWindowDimmer(actor).dimFraction = 1.0;
}, },
_undimWindow: function(window, animate) { _undimWindow: function(window) {
let actor = window.get_compositor_private(); let actor = window.get_compositor_private();
if (!actor) if (!actor)
return; return;
if (animate) Tweener.addTween(getWindowDimmer(actor),
Tweener.addTween(getWindowDimmer(actor), { dimFraction: 0.0,
{ dimFraction: 0.0, time: UNDIM_TIME,
time: UNDIM_TIME, transition: 'linear'
transition: 'linear' });
});
else
getWindowDimmer(actor).dimFraction = 0.0;
}, },
_mapWindow : function(shellwm, actor) { _mapWindow : function(shellwm, actor) {