brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

shell-app: Never allow opening new windows while an app is starting

Browse Source 
We allow opening new windows as a fallback in case the app doesn't give
us explicit information about it, but we don't want to allow opening new
windows if we're unable to ask for this information (we can only use the
APIs to get this information while the app is RUNNING).

So always return FALSE in case the app is STARTING, always return TRUE
in case the app is STOPPED (starting an app always opens a new window)
and go through the usual checks in case the app is RUNNING (and
eventually fall back to FALSE).

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/121
This commit is contained in:
Jonas Dreßler 2019-08-01 17:22:50 +02:00 committed by Florian Müllner
parent 942758bb30
commit 00e95de114
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/shell-app.c
View File

@ -604,10 +604,12 @@ shell_app_can_open_new_window (ShellApp *app)
GDesktopAppInfo *desktop_info;
const char * const *desktop_actions;
/* Apps that are not running can always open new windows, because
activating them would open the first one */
if (!app->running_state)
return TRUE;
/* Apps that are stopped can always open new windows, because
* activating them would open the first one; if they are starting,
* we cannot tell whether they can open additional windows until
* they are running */
if (app->state != SHELL_APP_STATE_RUNNING)
return app->state == SHELL_APP_STATE_STOPPED;
state = app->running_state;