brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

workspaceSwitcherPopup: Fix fading in

Browse Source 
The popover is supposed to fade in, but that's currently
broken because:

 - we already start at full opacity
 - Clutter skips transitions while unmapped

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2127>
This commit is contained in:
Florian Müllner 2022-01-26 01:43:15 +01:00 committed by Marge Bot
parent 209d8c7f10
commit 00ccea48a6
1 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
js/ui/workspaceSwitcherPopup.js
View File

@ -175,15 +175,6 @@ class WorkspaceSwitcherPopup extends St.Widget {
this._container.y = workArea.y + Math.floor((workArea.height - containerNatHeight) / 2); this._container.y = workArea.y + Math.floor((workArea.height - containerNatHeight) / 2);
} }
_show() {
this._container.ease({
opacity: 255,
duration: ANIMATION_TIME,
mode: Clutter.AnimationMode.EASE_OUT_QUAD,
});
this.show();
}
display(activeWorkspaceIndex) { display(activeWorkspaceIndex) {
this._activeWorkspaceIndex = activeWorkspaceIndex; this._activeWorkspaceIndex = activeWorkspaceIndex;
@ -192,7 +183,15 @@ class WorkspaceSwitcherPopup extends St.Widget {
GLib.source_remove(this._timeoutId); GLib.source_remove(this._timeoutId);
this._timeoutId = GLib.timeout_add(GLib.PRIORITY_DEFAULT, DISPLAY_TIMEOUT, this._onTimeout.bind(this)); this._timeoutId = GLib.timeout_add(GLib.PRIORITY_DEFAULT, DISPLAY_TIMEOUT, this._onTimeout.bind(this));
GLib.Source.set_name_by_id(this._timeoutId, '[gnome-shell] this._onTimeout'); GLib.Source.set_name_by_id(this._timeoutId, '[gnome-shell] this._onTimeout');
this._show();
const duration = this.visible ? 0 : ANIMATION_TIME;
this.show();
this._container.opacity = 0;
this._container.ease({
opacity: 255,
duration,
mode: Clutter.AnimationMode.EASE_OUT_QUAD,
});
} }
_onTimeout() { _onTimeout() {