From 0068098996ed3ca443060800fb3d754421186cdb Mon Sep 17 00:00:00 2001 From: Giovanni Campagna Date: Fri, 20 Mar 2015 12:39:01 -0700 Subject: [PATCH] Background: add a comment for questionable GSettings usage BackgroundSource relies on Background to watch its own settings. Add a comment to explain that. https://bugzilla.gnome.org/show_bug.cgi?id=746509 --- js/ui/background.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/js/ui/background.js b/js/ui/background.js index 82928e771..5acff9fda 100644 --- a/js/ui/background.js +++ b/js/ui/background.js @@ -527,6 +527,10 @@ const BackgroundSource = new Lang.Class({ let file = null; let style; + // We don't watch changes to settings here, + // instead we rely on Background to watch those + // and emit 'changed' at the right time + if (this._overrideImage != null) { file = Gio.File.new_for_path(this._overrideImage); style = GDesktopEnums.BackgroundStyle.ZOOM; // Hardcode