brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
3a1ebd86d2
gnome-shell/src/shell-blur-effect.c

908 lines
27 KiB
C
Raw Normal View History

Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
/* shell-blur-effect.c
*
* Copyright 2019 Georges Basile Stavracas Neto <georges.stavracas@gmail.com>
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
* SPDX-License-Identifier: GPL-3.0-or-later
*/
#include "shell-blur-effect.h"
#include "shell-enum-types.h"
/**
* SECTION:shell-blur-effect
* @short_description: Blur effect for actors
*
blur-effect: Use ClutterBlurNode With ClutterBlurNode available, we can remove our own implementation and delegate the blur shader and framebuffers. This simply replaces the pair of layer nodes (vblur and hblur) with a ClutterBlurNode, and removes all dead code. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1528>
2020-12-09 22:20:16 +00:00
* #ShellBlurEffect is a blur implementation based on Clutter. It also has
*: Fix spelling mistakes found by codespell https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1416
2020-08-19 09:26:11 +00:00
* an optional brightness property.
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
*
* # Modes
*
* #ShellBlurEffect can work in @SHELL_BLUR_MODE_BACKGROUND and @SHELL_BLUR_MODE_ACTOR
* modes. The actor mode blurs the actor itself, and all of its children. The
* background mode blurs the pixels beneath the actor, but not the actor itself.
*
* @SHELL_BLUR_MODE_BACKGROUND can be computationally expensive, since the contents
* beneath the actor cannot be cached, so beware of the performance implications
* of using this blur mode.
*/
static const gchar *brightness_glsl_declarations =
blur-effect: Implement incremental calculation of gauss coefficient Use the shader for linear sampling and incremental calculation of the gaussian kernel values as it was implemented by Patrick Walton in webrender. The sigma value for the blur (the standard deviation) is calculated by taking the blur radius and dividing it by 3, this value is used by most implementations of gaussian blurs since it covers a high percentage of the gaussian shape. The linear sampling optimization is implemented by skipping every second texel (i += 2) in the for-loop that's sampling adjacent texels. https://github.com/servo/webrender/blob/master/webrender/res/cs_blur.glsl https://github.com/servo/webrender/commit/38ec7db6f165ff7aaad12d91eca7d7a5f51557b5 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/991
2020-02-10 14:34:03 +00:00
"uniform float brightness; \n";
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
static const gchar *brightness_glsl =
blur-effect: Implement incremental calculation of gauss coefficient Use the shader for linear sampling and incremental calculation of the gaussian kernel values as it was implemented by Patrick Walton in webrender. The sigma value for the blur (the standard deviation) is calculated by taking the blur radius and dividing it by 3, this value is used by most implementations of gaussian blurs since it covers a high percentage of the gaussian shape. The linear sampling optimization is implemented by skipping every second texel (i += 2) in the for-loop that's sampling adjacent texels. https://github.com/servo/webrender/blob/master/webrender/res/cs_blur.glsl https://github.com/servo/webrender/commit/38ec7db6f165ff7aaad12d91eca7d7a5f51557b5 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/991
2020-02-10 14:34:03 +00:00
" cogl_color_out.rgb *= brightness; \n";
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
#define MIN_DOWNSCALE_SIZE 256.f
blur-effect: Use sigma value instead of blur radius Almost all implementations, including CSS [1] of gaussian blurs use the sigma/standard deviation value as the input parameter, even if they call that value "radius". Since using sigma is more correct mathematically and avoids confusion for people used to other blur implementations, use that parameter here, too. [1] https://www.w3.org/TR/filter-effects-1/#funcdef-filter-blur https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/991
2020-02-10 14:34:57 +00:00
#define MAX_SIGMA 6.f
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
typedef enum
{
ACTOR_PAINTED = 1 << 0,
BLUR_APPLIED = 1 << 1,
} CacheFlags;
typedef struct
{
CoglFramebuffer *framebuffer;
CoglPipeline *pipeline;
CoglTexture *texture;
} FramebufferData;
struct _ShellBlurEffect
{
ClutterEffect parent_instance;
ClutterActor *actor;
unsigned int tex_width;
unsigned int tex_height;
/* The cached contents */
FramebufferData actor_fb;
CacheFlags cache_flags;
FramebufferData background_fb;
FramebufferData brightness_fb;
int brightness_uniform;
ShellBlurMode mode;
float downscale_factor;
float brightness;
blur-effect: Use sigma value instead of blur radius Almost all implementations, including CSS [1] of gaussian blurs use the sigma/standard deviation value as the input parameter, even if they call that value "radius". Since using sigma is more correct mathematically and avoids confusion for people used to other blur implementations, use that parameter here, too. [1] https://www.w3.org/TR/filter-effects-1/#funcdef-filter-blur https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/991
2020-02-10 14:34:57 +00:00
int sigma;
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
};
G_DEFINE_TYPE (ShellBlurEffect, shell_blur_effect, CLUTTER_TYPE_EFFECT)
enum {
PROP_0,
blur-effect: Use sigma value instead of blur radius Almost all implementations, including CSS [1] of gaussian blurs use the sigma/standard deviation value as the input parameter, even if they call that value "radius". Since using sigma is more correct mathematically and avoids confusion for people used to other blur implementations, use that parameter here, too. [1] https://www.w3.org/TR/filter-effects-1/#funcdef-filter-blur https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/991
2020-02-10 14:34:57 +00:00
PROP_SIGMA,
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
PROP_BRIGHTNESS,
PROP_MODE,
N_PROPS
};
static GParamSpec *properties [N_PROPS] = { NULL, };
static CoglPipeline*
create_base_pipeline (void)
{
static CoglPipeline *base_pipeline = NULL;
if (G_UNLIKELY (base_pipeline == NULL))
{
CoglContext *ctx =
clutter_backend_get_cogl_context (clutter_get_default_backend ());
base_pipeline = cogl_pipeline_new (ctx);
cogl_pipeline_set_layer_null_texture (base_pipeline, 0);
cogl_pipeline_set_layer_filters (base_pipeline,
0,
COGL_PIPELINE_FILTER_LINEAR,
COGL_PIPELINE_FILTER_LINEAR);
cogl_pipeline_set_layer_wrap_mode (base_pipeline,
0,
COGL_PIPELINE_WRAP_MODE_CLAMP_TO_EDGE);
}
return cogl_pipeline_copy (base_pipeline);
}
static CoglPipeline*
create_brightness_pipeline (void)
{
static CoglPipeline *brightness_pipeline = NULL;
if (G_UNLIKELY (brightness_pipeline == NULL))
{
CoglSnippet *snippet;
brightness_pipeline = create_base_pipeline ();
snippet = cogl_snippet_new (COGL_SNIPPET_HOOK_FRAGMENT,
brightness_glsl_declarations,
brightness_glsl);
cogl_pipeline_add_snippet (brightness_pipeline, snippet);
cogl_object_unref (snippet);
}
return cogl_pipeline_copy (brightness_pipeline);
}
static void
blur-effect: Use ClutterBlurNode With ClutterBlurNode available, we can remove our own implementation and delegate the blur shader and framebuffers. This simply replaces the pair of layer nodes (vblur and hblur) with a ClutterBlurNode, and removes all dead code. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1528>
2020-12-09 22:20:16 +00:00
update_brightness (ShellBlurEffect *self,
uint8_t paint_opacity)
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
{
blur-effect: Use ClutterBlurNode With ClutterBlurNode available, we can remove our own implementation and delegate the blur shader and framebuffers. This simply replaces the pair of layer nodes (vblur and hblur) with a ClutterBlurNode, and removes all dead code. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1528>
2020-12-09 22:20:16 +00:00
cogl_pipeline_set_color4ub (self->brightness_fb.pipeline,
paint_opacity,
paint_opacity,
paint_opacity,
paint_opacity);
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
if (self->brightness_uniform > -1)
{
cogl_pipeline_set_uniform_1f (self->brightness_fb.pipeline,
self->brightness_uniform,
self->brightness);
}
}
static void
setup_projection_matrix (CoglFramebuffer *framebuffer,
float width,
blur-effect: Floor downscaled frambuffer sizes Floor the downscaled size of the new framebuffer to make sure we don't initialize a framebuffer with a floating point value that might be interpreted wrong by `cogl_texture_2d_new_with_size` and end up with a slightly wrong aspect ratio of the framebuffer. This fixes situations where the widths or heights of downscaled framebuffers sometimes miss some pixels at the border. While at it, remove the `downscale_factor` argument from `setup_projection_matrix` since that function doesn't need the initial size of the actor anyway. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/991
2020-02-10 14:22:33 +00:00
float height)
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
{
Replace CoglMatrix by graphene_matrix_t Replace both the types, and the cogl_matrix_* API calls with the corresponding graphene_matrix_* ones. https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1436
2020-09-11 18:49:29 +00:00
graphene_matrix_t projection;
graphene_matrix_init_translate (&projection,
&GRAPHENE_POINT3D_INIT (-width / 2.0,
-height / 2.0,
0.f));
graphene_matrix_scale (&projection, 2.0 / width, -2.0 / height, 1.f);
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
cogl_framebuffer_set_projection_matrix (framebuffer, &projection);
}
static gboolean
update_fbo (FramebufferData *data,
unsigned int width,
unsigned int height,
float downscale_factor)
{
CoglContext *ctx =
clutter_backend_get_cogl_context (clutter_get_default_backend ());
g_clear_pointer (&data->texture, cogl_object_unref);
Adapt to CoglFramebuffers turning into GObjects Requires some more explicit type casting as things turned into 'void *' less. Also memory management changes, as we can't use CoglObject functions anymore for these objects. https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1465
2020-10-13 13:51:22 +00:00
g_clear_object (&data->framebuffer);
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
blur-effect: Floor downscaled frambuffer sizes Floor the downscaled size of the new framebuffer to make sure we don't initialize a framebuffer with a floating point value that might be interpreted wrong by `cogl_texture_2d_new_with_size` and end up with a slightly wrong aspect ratio of the framebuffer. This fixes situations where the widths or heights of downscaled framebuffers sometimes miss some pixels at the border. While at it, remove the `downscale_factor` argument from `setup_projection_matrix` since that function doesn't need the initial size of the actor anyway. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/991
2020-02-10 14:22:33 +00:00
float new_width = floorf (width / downscale_factor);
float new_height = floorf (height / downscale_factor);
data->texture = cogl_texture_2d_new_with_size (ctx, new_width, new_height);
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
if (!data->texture)
return FALSE;
cogl_pipeline_set_layer_texture (data->pipeline, 0, data->texture);
Adapt to CoglFramebuffers turning into GObjects Requires some more explicit type casting as things turned into 'void *' less. Also memory management changes, as we can't use CoglObject functions anymore for these objects. https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1465
2020-10-13 13:51:22 +00:00
data->framebuffer =
COGL_FRAMEBUFFER (cogl_offscreen_new_with_texture (data->texture));
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
if (!data->framebuffer)
{
g_warning ("%s: Unable to create an Offscreen buffer", G_STRLOC);
return FALSE;
}
blur-effect: Floor downscaled frambuffer sizes Floor the downscaled size of the new framebuffer to make sure we don't initialize a framebuffer with a floating point value that might be interpreted wrong by `cogl_texture_2d_new_with_size` and end up with a slightly wrong aspect ratio of the framebuffer. This fixes situations where the widths or heights of downscaled framebuffers sometimes miss some pixels at the border. While at it, remove the `downscale_factor` argument from `setup_projection_matrix` since that function doesn't need the initial size of the actor anyway. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/991
2020-02-10 14:22:33 +00:00
setup_projection_matrix (data->framebuffer, new_width, new_height);
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
return TRUE;
}
static gboolean
update_actor_fbo (ShellBlurEffect *self,
unsigned int width,
unsigned int height,
float downscale_factor)
{
if (self->tex_width == width &&
self->tex_height == height &&
self->downscale_factor == downscale_factor &&
self->actor_fb.framebuffer)
{
return TRUE;
}
self->cache_flags &= ~ACTOR_PAINTED;
return update_fbo (&self->actor_fb, width, height, downscale_factor);
}
static gboolean
update_brightness_fbo (ShellBlurEffect *self,
unsigned int width,
unsigned int height,
float downscale_factor)
{
if (self->tex_width == width &&
self->tex_height == height &&
self->downscale_factor == downscale_factor &&
self->brightness_fb.framebuffer)
{
return TRUE;
}
return update_fbo (&self->brightness_fb,
width, height,
downscale_factor);
}
static gboolean
update_background_fbo (ShellBlurEffect *self,
blur-effect: Fix alignment of function arguments https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/1000
2020-02-13 12:07:55 +00:00
unsigned int width,
unsigned int height)
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
{
if (self->tex_width == width &&
self->tex_height == height &&
self->background_fb.framebuffer)
{
return TRUE;
}
return update_fbo (&self->background_fb, width, height, 1.0);
}
static void
clear_framebuffer_data (FramebufferData *fb_data)
{
g_clear_pointer (&fb_data->texture, cogl_object_unref);
Adapt to CoglFramebuffers turning into GObjects Requires some more explicit type casting as things turned into 'void *' less. Also memory management changes, as we can't use CoglObject functions anymore for these objects. https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1465
2020-10-13 13:51:22 +00:00
g_clear_object (&fb_data->framebuffer);
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
}
static float
calculate_downscale_factor (float width,
float height,
blur-effect: Use sigma value instead of blur radius Almost all implementations, including CSS [1] of gaussian blurs use the sigma/standard deviation value as the input parameter, even if they call that value "radius". Since using sigma is more correct mathematically and avoids confusion for people used to other blur implementations, use that parameter here, too. [1] https://www.w3.org/TR/filter-effects-1/#funcdef-filter-blur https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/991
2020-02-10 14:34:57 +00:00
float sigma)
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
{
float downscale_factor = 1.0;
float scaled_width = width;
float scaled_height = height;
blur-effect: Use sigma value instead of blur radius Almost all implementations, including CSS [1] of gaussian blurs use the sigma/standard deviation value as the input parameter, even if they call that value "radius". Since using sigma is more correct mathematically and avoids confusion for people used to other blur implementations, use that parameter here, too. [1] https://www.w3.org/TR/filter-effects-1/#funcdef-filter-blur https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/991
2020-02-10 14:34:57 +00:00
float scaled_sigma = sigma;
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
/* This is the algorithm used by Firefox; keep downscaling until either the
* blur radius is lower than the threshold, or the downscaled texture is too
* small.
*/
blur-effect: Use sigma value instead of blur radius Almost all implementations, including CSS [1] of gaussian blurs use the sigma/standard deviation value as the input parameter, even if they call that value "radius". Since using sigma is more correct mathematically and avoids confusion for people used to other blur implementations, use that parameter here, too. [1] https://www.w3.org/TR/filter-effects-1/#funcdef-filter-blur https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/991
2020-02-10 14:34:57 +00:00
while (scaled_sigma > MAX_SIGMA &&
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
scaled_width > MIN_DOWNSCALE_SIZE &&
scaled_height > MIN_DOWNSCALE_SIZE)
{
downscale_factor *= 2.f;
scaled_width = width / downscale_factor;
scaled_height = height / downscale_factor;
blur-effect: Use sigma value instead of blur radius Almost all implementations, including CSS [1] of gaussian blurs use the sigma/standard deviation value as the input parameter, even if they call that value "radius". Since using sigma is more correct mathematically and avoids confusion for people used to other blur implementations, use that parameter here, too. [1] https://www.w3.org/TR/filter-effects-1/#funcdef-filter-blur https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/991
2020-02-10 14:34:57 +00:00
scaled_sigma = sigma / downscale_factor;
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
}
return downscale_factor;
}
static void
shell_blur_effect_set_actor (ClutterActorMeta *meta,
ClutterActor *actor)
{
ShellBlurEffect *self = SHELL_BLUR_EFFECT (meta);
ClutterActorMetaClass *meta_class;
meta_class = CLUTTER_ACTOR_META_CLASS (shell_blur_effect_parent_class);
meta_class->set_actor (meta, actor);
/* clear out the previous state */
clear_framebuffer_data (&self->actor_fb);
blur-effect: Properly clear background framebuffer We want to completely clear the background framebuffer when switching back to ACTOR mode to make sure the `background_fb.framebuffer` check will fail in `update_background_fbo` when switching to BACKGROUND mode again. Otherwise the checks in `update_background_fbo` will return TRUE and we will keep using the background framebuffer that was created before switchig to ACTOR mode. While at it, also clear the background framebuffer completely when changing the actor to avoid the same issue here. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/1000
2020-02-13 12:08:28 +00:00
clear_framebuffer_data (&self->background_fb);
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
clear_framebuffer_data (&self->brightness_fb);
/* we keep a back pointer here, to avoid going through the ActorMeta */
self->actor = clutter_actor_meta_get_actor (meta);
}
static void
blur-effect: Fix framebuffer sizes when stage-view scaling is used When blurring only the actor (ACTOR mode), we don't want to apply any scale, it looks fine without using the resource scale and it also seems like `clutter_actor_continue_paint` in `paint_actor_offscreen` only draws an unscaled texture anyway (ie. if the resource scale is 2, only a quarter of the framebuffer is being drawn to). In BACKGROUND mode though, we need to scale the framebuffer using the scale factor of the stage view (ie. the final scale factor for the monitor) because the content of the framebuffer we blit is scaled using that factor. Also, since the framebuffer we blit belongs to a stage view and only includes the contents of this view, we need to adjust the stage-coordinates of the actor to be relative to the stage-view. To make sure we don't have to get the transformed actor size or position multiple times during one paint-run and don't have to carefully floor() or ceil() widths and positions, store the size of the actor (which is also the size of the framebuffer) and its position relative to the stage view inside a ClutterActorBox. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/1000
2020-02-12 22:02:14 +00:00
update_actor_box (ShellBlurEffect *self,
ClutterPaintContext *paint_context,
ClutterActorBox *source_actor_box)
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
{
blur-effect: Fix framebuffer sizes when stage-view scaling is used When blurring only the actor (ACTOR mode), we don't want to apply any scale, it looks fine without using the resource scale and it also seems like `clutter_actor_continue_paint` in `paint_actor_offscreen` only draws an unscaled texture anyway (ie. if the resource scale is 2, only a quarter of the framebuffer is being drawn to). In BACKGROUND mode though, we need to scale the framebuffer using the scale factor of the stage view (ie. the final scale factor for the monitor) because the content of the framebuffer we blit is scaled using that factor. Also, since the framebuffer we blit belongs to a stage view and only includes the contents of this view, we need to adjust the stage-coordinates of the actor to be relative to the stage-view. To make sure we don't have to get the transformed actor size or position multiple times during one paint-run and don't have to carefully floor() or ceil() widths and positions, store the size of the actor (which is also the size of the framebuffer) and its position relative to the stage view inside a ClutterActorBox. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/1000
2020-02-12 22:02:14 +00:00
ClutterStageView *stage_view;
float box_scale_factor = 1.0f;
float origin_x, origin_y;
float width, height;
switch (self->mode)
{
case SHELL_BLUR_MODE_ACTOR:
clutter_actor_get_allocation_box (self->actor, source_actor_box);
break;
case SHELL_BLUR_MODE_BACKGROUND:
stage_view = clutter_paint_context_get_stage_view (paint_context);
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
blur-effect: Fix framebuffer sizes when stage-view scaling is used When blurring only the actor (ACTOR mode), we don't want to apply any scale, it looks fine without using the resource scale and it also seems like `clutter_actor_continue_paint` in `paint_actor_offscreen` only draws an unscaled texture anyway (ie. if the resource scale is 2, only a quarter of the framebuffer is being drawn to). In BACKGROUND mode though, we need to scale the framebuffer using the scale factor of the stage view (ie. the final scale factor for the monitor) because the content of the framebuffer we blit is scaled using that factor. Also, since the framebuffer we blit belongs to a stage view and only includes the contents of this view, we need to adjust the stage-coordinates of the actor to be relative to the stage-view. To make sure we don't have to get the transformed actor size or position multiple times during one paint-run and don't have to carefully floor() or ceil() widths and positions, store the size of the actor (which is also the size of the framebuffer) and its position relative to the stage view inside a ClutterActorBox. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/1000
2020-02-12 22:02:14 +00:00
clutter_actor_get_transformed_position (self->actor, &origin_x, &origin_y);
clutter_actor_get_transformed_size (self->actor, &width, &height);
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
blur-effect: Don't use stage view when drawing off-stage When we're painting off-stage, for example because we're screencasting or taking a screenshot, there won't be a stage-view associated with the paint context. The BlurEffect previously didn't handle that case and would crash. Fix that and handle that case by assuming the scale is 1 and not offsetting the rectangle we blit from the draw framebuffer. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1673>
2021-02-13 15:07:22 +00:00
if (stage_view)
{
cairo_rectangle_int_t stage_view_layout;
box_scale_factor = clutter_stage_view_get_scale (stage_view);
clutter_stage_view_get_layout (stage_view, &stage_view_layout);
origin_x -= stage_view_layout.x;
origin_y -= stage_view_layout.y;
}
else
{
/* If we're drawing off stage, just assume scale = 1, this won't work
* with stage-view scaling though.
*/
}
blur-effect: Fix framebuffer sizes when stage-view scaling is used When blurring only the actor (ACTOR mode), we don't want to apply any scale, it looks fine without using the resource scale and it also seems like `clutter_actor_continue_paint` in `paint_actor_offscreen` only draws an unscaled texture anyway (ie. if the resource scale is 2, only a quarter of the framebuffer is being drawn to). In BACKGROUND mode though, we need to scale the framebuffer using the scale factor of the stage view (ie. the final scale factor for the monitor) because the content of the framebuffer we blit is scaled using that factor. Also, since the framebuffer we blit belongs to a stage view and only includes the contents of this view, we need to adjust the stage-coordinates of the actor to be relative to the stage-view. To make sure we don't have to get the transformed actor size or position multiple times during one paint-run and don't have to carefully floor() or ceil() widths and positions, store the size of the actor (which is also the size of the framebuffer) and its position relative to the stage view inside a ClutterActorBox. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/1000
2020-02-12 22:02:14 +00:00
clutter_actor_box_set_origin (source_actor_box, origin_x, origin_y);
clutter_actor_box_set_size (source_actor_box, width, height);
clutter_actor_box_scale (source_actor_box, box_scale_factor);
break;
}
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
blur-effect: Fix framebuffer sizes when stage-view scaling is used When blurring only the actor (ACTOR mode), we don't want to apply any scale, it looks fine without using the resource scale and it also seems like `clutter_actor_continue_paint` in `paint_actor_offscreen` only draws an unscaled texture anyway (ie. if the resource scale is 2, only a quarter of the framebuffer is being drawn to). In BACKGROUND mode though, we need to scale the framebuffer using the scale factor of the stage view (ie. the final scale factor for the monitor) because the content of the framebuffer we blit is scaled using that factor. Also, since the framebuffer we blit belongs to a stage view and only includes the contents of this view, we need to adjust the stage-coordinates of the actor to be relative to the stage-view. To make sure we don't have to get the transformed actor size or position multiple times during one paint-run and don't have to carefully floor() or ceil() widths and positions, store the size of the actor (which is also the size of the framebuffer) and its position relative to the stage view inside a ClutterActorBox. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/1000
2020-02-12 22:02:14 +00:00
clutter_actor_box_clamp_to_pixel (source_actor_box);
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
}
static void
blur-effect: Port to paint nodes Port the blur effect to the new ClutterEffect.paint_node() vfunc. Update the function names to match what they do, e.g. "apply_blur()" now creates the blur subtree and thus was appropriately renamed to "create_blur_nodes()". There are 3 subtrees that can be generated by the blur effect: 1. Actor mode (full subtree; no cache) Root | | Layer (brightness) | Layer (horizontal blur) | Layer (vertical blur) | Layer (actor) | Transform (downscale) | Actor 2. Actor mode (partial subtree; cached contents) Root | Pipeline (final result) 3. Background mode Root |----------------------- | | Layer (brightness) Actor | Layer (horizontal blur) | Layer (vertical blur) | Layer (background) | Blit Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1339>
2020-06-29 18:35:02 +00:00
add_blurred_pipeline (ShellBlurEffect *self,
blur-effect: Use ClutterBlurNode With ClutterBlurNode available, we can remove our own implementation and delegate the blur shader and framebuffers. This simply replaces the pair of layer nodes (vblur and hblur) with a ClutterBlurNode, and removes all dead code. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1528>
2020-12-09 22:20:16 +00:00
ClutterPaintNode *node,
uint8_t paint_opacity)
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
{
blur-effect: Port to paint nodes Port the blur effect to the new ClutterEffect.paint_node() vfunc. Update the function names to match what they do, e.g. "apply_blur()" now creates the blur subtree and thus was appropriately renamed to "create_blur_nodes()". There are 3 subtrees that can be generated by the blur effect: 1. Actor mode (full subtree; no cache) Root | | Layer (brightness) | Layer (horizontal blur) | Layer (vertical blur) | Layer (actor) | Transform (downscale) | Actor 2. Actor mode (partial subtree; cached contents) Root | Pipeline (final result) 3. Background mode Root |----------------------- | | Layer (brightness) Actor | Layer (horizontal blur) | Layer (vertical blur) | Layer (background) | Blit Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1339>
2020-06-29 18:35:02 +00:00
g_autoptr (ClutterPaintNode) pipeline_node = NULL;
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
float width, height;
/* Use the untransformed actor size here, since the framebuffer itself already
* has the actor transform matrix applied.
*/
clutter_actor_get_size (self->actor, &width, &height);
blur-effect: Use ClutterBlurNode With ClutterBlurNode available, we can remove our own implementation and delegate the blur shader and framebuffers. This simply replaces the pair of layer nodes (vblur and hblur) with a ClutterBlurNode, and removes all dead code. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1528>
2020-12-09 22:20:16 +00:00
update_brightness (self, paint_opacity);
blur-effect: Port to paint nodes Port the blur effect to the new ClutterEffect.paint_node() vfunc. Update the function names to match what they do, e.g. "apply_blur()" now creates the blur subtree and thus was appropriately renamed to "create_blur_nodes()". There are 3 subtrees that can be generated by the blur effect: 1. Actor mode (full subtree; no cache) Root | | Layer (brightness) | Layer (horizontal blur) | Layer (vertical blur) | Layer (actor) | Transform (downscale) | Actor 2. Actor mode (partial subtree; cached contents) Root | Pipeline (final result) 3. Background mode Root |----------------------- | | Layer (brightness) Actor | Layer (horizontal blur) | Layer (vertical blur) | Layer (background) | Blit Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1339>
2020-06-29 18:35:02 +00:00
pipeline_node = clutter_pipeline_node_new (self->brightness_fb.pipeline);
clutter_paint_node_set_static_name (pipeline_node, "ShellBlurEffect (final)");
clutter_paint_node_add_child (node, pipeline_node);
clutter_paint_node_add_rectangle (pipeline_node,
&(ClutterActorBox) {
0.f, 0.f,
width,
height,
});
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
}
blur-effect: Port to paint nodes Port the blur effect to the new ClutterEffect.paint_node() vfunc. Update the function names to match what they do, e.g. "apply_blur()" now creates the blur subtree and thus was appropriately renamed to "create_blur_nodes()". There are 3 subtrees that can be generated by the blur effect: 1. Actor mode (full subtree; no cache) Root | | Layer (brightness) | Layer (horizontal blur) | Layer (vertical blur) | Layer (actor) | Transform (downscale) | Actor 2. Actor mode (partial subtree; cached contents) Root | Pipeline (final result) 3. Background mode Root |----------------------- | | Layer (brightness) Actor | Layer (horizontal blur) | Layer (vertical blur) | Layer (background) | Blit Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1339>
2020-06-29 18:35:02 +00:00
static ClutterPaintNode *
create_blur_nodes (ShellBlurEffect *self,
ClutterPaintNode *node,
uint8_t paint_opacity)
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
{
blur-effect: Port to paint nodes Port the blur effect to the new ClutterEffect.paint_node() vfunc. Update the function names to match what they do, e.g. "apply_blur()" now creates the blur subtree and thus was appropriately renamed to "create_blur_nodes()". There are 3 subtrees that can be generated by the blur effect: 1. Actor mode (full subtree; no cache) Root | | Layer (brightness) | Layer (horizontal blur) | Layer (vertical blur) | Layer (actor) | Transform (downscale) | Actor 2. Actor mode (partial subtree; cached contents) Root | Pipeline (final result) 3. Background mode Root |----------------------- | | Layer (brightness) Actor | Layer (horizontal blur) | Layer (vertical blur) | Layer (background) | Blit Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1339>
2020-06-29 18:35:02 +00:00
g_autoptr (ClutterPaintNode) brightness_node = NULL;
blur-effect: Use ClutterBlurNode With ClutterBlurNode available, we can remove our own implementation and delegate the blur shader and framebuffers. This simply replaces the pair of layer nodes (vblur and hblur) with a ClutterBlurNode, and removes all dead code. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1528>
2020-12-09 22:20:16 +00:00
g_autoptr (ClutterPaintNode) blur_node = NULL;
blur-effect: Port to paint nodes Port the blur effect to the new ClutterEffect.paint_node() vfunc. Update the function names to match what they do, e.g. "apply_blur()" now creates the blur subtree and thus was appropriately renamed to "create_blur_nodes()". There are 3 subtrees that can be generated by the blur effect: 1. Actor mode (full subtree; no cache) Root | | Layer (brightness) | Layer (horizontal blur) | Layer (vertical blur) | Layer (actor) | Transform (downscale) | Actor 2. Actor mode (partial subtree; cached contents) Root | Pipeline (final result) 3. Background mode Root |----------------------- | | Layer (brightness) Actor | Layer (horizontal blur) | Layer (vertical blur) | Layer (background) | Blit Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1339>
2020-06-29 18:35:02 +00:00
float width;
float height;
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
blur-effect: Port to paint nodes Port the blur effect to the new ClutterEffect.paint_node() vfunc. Update the function names to match what they do, e.g. "apply_blur()" now creates the blur subtree and thus was appropriately renamed to "create_blur_nodes()". There are 3 subtrees that can be generated by the blur effect: 1. Actor mode (full subtree; no cache) Root | | Layer (brightness) | Layer (horizontal blur) | Layer (vertical blur) | Layer (actor) | Transform (downscale) | Actor 2. Actor mode (partial subtree; cached contents) Root | Pipeline (final result) 3. Background mode Root |----------------------- | | Layer (brightness) Actor | Layer (horizontal blur) | Layer (vertical blur) | Layer (background) | Blit Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1339>
2020-06-29 18:35:02 +00:00
clutter_actor_get_size (self->actor, &width, &height);
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
blur-effect: Use ClutterBlurNode With ClutterBlurNode available, we can remove our own implementation and delegate the blur shader and framebuffers. This simply replaces the pair of layer nodes (vblur and hblur) with a ClutterBlurNode, and removes all dead code. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1528>
2020-12-09 22:20:16 +00:00
update_brightness (self, paint_opacity);
blur-effect: Port to paint nodes Port the blur effect to the new ClutterEffect.paint_node() vfunc. Update the function names to match what they do, e.g. "apply_blur()" now creates the blur subtree and thus was appropriately renamed to "create_blur_nodes()". There are 3 subtrees that can be generated by the blur effect: 1. Actor mode (full subtree; no cache) Root | | Layer (brightness) | Layer (horizontal blur) | Layer (vertical blur) | Layer (actor) | Transform (downscale) | Actor 2. Actor mode (partial subtree; cached contents) Root | Pipeline (final result) 3. Background mode Root |----------------------- | | Layer (brightness) Actor | Layer (horizontal blur) | Layer (vertical blur) | Layer (background) | Blit Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1339>
2020-06-29 18:35:02 +00:00
brightness_node = clutter_layer_node_new_to_framebuffer (self->brightness_fb.framebuffer,
self->brightness_fb.pipeline);
clutter_paint_node_set_static_name (brightness_node, "ShellBlurEffect (brightness)");
clutter_paint_node_add_child (node, brightness_node);
clutter_paint_node_add_rectangle (brightness_node,
&(ClutterActorBox) {
0.f, 0.f,
width, height,
});
blur-effect: Use ClutterBlurNode With ClutterBlurNode available, we can remove our own implementation and delegate the blur shader and framebuffers. This simply replaces the pair of layer nodes (vblur and hblur) with a ClutterBlurNode, and removes all dead code. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1528>
2020-12-09 22:20:16 +00:00
blur_node = clutter_blur_node_new (self->tex_width / self->downscale_factor,
self->tex_height / self->downscale_factor,
self->sigma / self->downscale_factor);
clutter_paint_node_set_static_name (blur_node, "ShellBlurEffect (blur)");
clutter_paint_node_add_child (brightness_node, blur_node);
clutter_paint_node_add_rectangle (blur_node,
blur-effect: Port to paint nodes Port the blur effect to the new ClutterEffect.paint_node() vfunc. Update the function names to match what they do, e.g. "apply_blur()" now creates the blur subtree and thus was appropriately renamed to "create_blur_nodes()". There are 3 subtrees that can be generated by the blur effect: 1. Actor mode (full subtree; no cache) Root | | Layer (brightness) | Layer (horizontal blur) | Layer (vertical blur) | Layer (actor) | Transform (downscale) | Actor 2. Actor mode (partial subtree; cached contents) Root | Pipeline (final result) 3. Background mode Root |----------------------- | | Layer (brightness) Actor | Layer (horizontal blur) | Layer (vertical blur) | Layer (background) | Blit Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1339>
2020-06-29 18:35:02 +00:00
&(ClutterActorBox) {
0.f, 0.f,
cogl_texture_get_width (self->brightness_fb.texture),
cogl_texture_get_height (self->brightness_fb.texture),
});
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
self->cache_flags |= BLUR_APPLIED;
blur-effect: Port to paint nodes Port the blur effect to the new ClutterEffect.paint_node() vfunc. Update the function names to match what they do, e.g. "apply_blur()" now creates the blur subtree and thus was appropriately renamed to "create_blur_nodes()". There are 3 subtrees that can be generated by the blur effect: 1. Actor mode (full subtree; no cache) Root | | Layer (brightness) | Layer (horizontal blur) | Layer (vertical blur) | Layer (actor) | Transform (downscale) | Actor 2. Actor mode (partial subtree; cached contents) Root | Pipeline (final result) 3. Background mode Root |----------------------- | | Layer (brightness) Actor | Layer (horizontal blur) | Layer (vertical blur) | Layer (background) | Blit Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1339>
2020-06-29 18:35:02 +00:00
blur-effect: Use ClutterBlurNode With ClutterBlurNode available, we can remove our own implementation and delegate the blur shader and framebuffers. This simply replaces the pair of layer nodes (vblur and hblur) with a ClutterBlurNode, and removes all dead code. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1528>
2020-12-09 22:20:16 +00:00
return g_steal_pointer (&blur_node);
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
}
blur-effect: Port to paint nodes Port the blur effect to the new ClutterEffect.paint_node() vfunc. Update the function names to match what they do, e.g. "apply_blur()" now creates the blur subtree and thus was appropriately renamed to "create_blur_nodes()". There are 3 subtrees that can be generated by the blur effect: 1. Actor mode (full subtree; no cache) Root | | Layer (brightness) | Layer (horizontal blur) | Layer (vertical blur) | Layer (actor) | Transform (downscale) | Actor 2. Actor mode (partial subtree; cached contents) Root | Pipeline (final result) 3. Background mode Root |----------------------- | | Layer (brightness) Actor | Layer (horizontal blur) | Layer (vertical blur) | Layer (background) | Blit Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1339>
2020-06-29 18:35:02 +00:00
static void
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
paint_background (ShellBlurEffect *self,
blur-effect: Port to paint nodes Port the blur effect to the new ClutterEffect.paint_node() vfunc. Update the function names to match what they do, e.g. "apply_blur()" now creates the blur subtree and thus was appropriately renamed to "create_blur_nodes()". There are 3 subtrees that can be generated by the blur effect: 1. Actor mode (full subtree; no cache) Root | | Layer (brightness) | Layer (horizontal blur) | Layer (vertical blur) | Layer (actor) | Transform (downscale) | Actor 2. Actor mode (partial subtree; cached contents) Root | Pipeline (final result) 3. Background mode Root |----------------------- | | Layer (brightness) Actor | Layer (horizontal blur) | Layer (vertical blur) | Layer (background) | Blit Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1339>
2020-06-29 18:35:02 +00:00
ClutterPaintNode *node,
blur-effect: Fix framebuffer sizes when stage-view scaling is used When blurring only the actor (ACTOR mode), we don't want to apply any scale, it looks fine without using the resource scale and it also seems like `clutter_actor_continue_paint` in `paint_actor_offscreen` only draws an unscaled texture anyway (ie. if the resource scale is 2, only a quarter of the framebuffer is being drawn to). In BACKGROUND mode though, we need to scale the framebuffer using the scale factor of the stage view (ie. the final scale factor for the monitor) because the content of the framebuffer we blit is scaled using that factor. Also, since the framebuffer we blit belongs to a stage view and only includes the contents of this view, we need to adjust the stage-coordinates of the actor to be relative to the stage-view. To make sure we don't have to get the transformed actor size or position multiple times during one paint-run and don't have to carefully floor() or ceil() widths and positions, store the size of the actor (which is also the size of the framebuffer) and its position relative to the stage view inside a ClutterActorBox. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/1000
2020-02-12 22:02:14 +00:00
ClutterPaintContext *paint_context,
ClutterActorBox *source_actor_box)
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
{
blur-effect: Port to paint nodes Port the blur effect to the new ClutterEffect.paint_node() vfunc. Update the function names to match what they do, e.g. "apply_blur()" now creates the blur subtree and thus was appropriately renamed to "create_blur_nodes()". There are 3 subtrees that can be generated by the blur effect: 1. Actor mode (full subtree; no cache) Root | | Layer (brightness) | Layer (horizontal blur) | Layer (vertical blur) | Layer (actor) | Transform (downscale) | Actor 2. Actor mode (partial subtree; cached contents) Root | Pipeline (final result) 3. Background mode Root |----------------------- | | Layer (brightness) Actor | Layer (horizontal blur) | Layer (vertical blur) | Layer (background) | Blit Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1339>
2020-06-29 18:35:02 +00:00
g_autoptr (ClutterPaintNode) background_node = NULL;
g_autoptr (ClutterPaintNode) blit_node = NULL;
CoglFramebuffer *src;
blur-effect: Fix framebuffer sizes when stage-view scaling is used When blurring only the actor (ACTOR mode), we don't want to apply any scale, it looks fine without using the resource scale and it also seems like `clutter_actor_continue_paint` in `paint_actor_offscreen` only draws an unscaled texture anyway (ie. if the resource scale is 2, only a quarter of the framebuffer is being drawn to). In BACKGROUND mode though, we need to scale the framebuffer using the scale factor of the stage view (ie. the final scale factor for the monitor) because the content of the framebuffer we blit is scaled using that factor. Also, since the framebuffer we blit belongs to a stage view and only includes the contents of this view, we need to adjust the stage-coordinates of the actor to be relative to the stage-view. To make sure we don't have to get the transformed actor size or position multiple times during one paint-run and don't have to carefully floor() or ceil() widths and positions, store the size of the actor (which is also the size of the framebuffer) and its position relative to the stage view inside a ClutterActorBox. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/1000
2020-02-12 22:02:14 +00:00
float transformed_x;
float transformed_y;
float transformed_width;
float transformed_height;
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
blur-effect: Fix framebuffer sizes when stage-view scaling is used When blurring only the actor (ACTOR mode), we don't want to apply any scale, it looks fine without using the resource scale and it also seems like `clutter_actor_continue_paint` in `paint_actor_offscreen` only draws an unscaled texture anyway (ie. if the resource scale is 2, only a quarter of the framebuffer is being drawn to). In BACKGROUND mode though, we need to scale the framebuffer using the scale factor of the stage view (ie. the final scale factor for the monitor) because the content of the framebuffer we blit is scaled using that factor. Also, since the framebuffer we blit belongs to a stage view and only includes the contents of this view, we need to adjust the stage-coordinates of the actor to be relative to the stage-view. To make sure we don't have to get the transformed actor size or position multiple times during one paint-run and don't have to carefully floor() or ceil() widths and positions, store the size of the actor (which is also the size of the framebuffer) and its position relative to the stage view inside a ClutterActorBox. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/1000
2020-02-12 22:02:14 +00:00
clutter_actor_box_get_origin (source_actor_box,
&transformed_x,
&transformed_y);
clutter_actor_box_get_size (source_actor_box,
&transformed_width,
&transformed_height);
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
blur-effect: Port to paint nodes Port the blur effect to the new ClutterEffect.paint_node() vfunc. Update the function names to match what they do, e.g. "apply_blur()" now creates the blur subtree and thus was appropriately renamed to "create_blur_nodes()". There are 3 subtrees that can be generated by the blur effect: 1. Actor mode (full subtree; no cache) Root | | Layer (brightness) | Layer (horizontal blur) | Layer (vertical blur) | Layer (actor) | Transform (downscale) | Actor 2. Actor mode (partial subtree; cached contents) Root | Pipeline (final result) 3. Background mode Root |----------------------- | | Layer (brightness) Actor | Layer (horizontal blur) | Layer (vertical blur) | Layer (background) | Blit Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1339>
2020-06-29 18:35:02 +00:00
/* Background layer node */
background_node =
clutter_layer_node_new_to_framebuffer (self->background_fb.framebuffer,
self->background_fb.pipeline);
clutter_paint_node_set_static_name (background_node, "ShellBlurEffect (background)");
clutter_paint_node_add_child (node, background_node);
clutter_paint_node_add_rectangle (background_node,
&(ClutterActorBox) {
0.f, 0.f,
self->tex_width / self->downscale_factor,
self->tex_height / self->downscale_factor,
});
/* Blit node */
src = clutter_paint_context_get_framebuffer (paint_context);
blit_node = clutter_blit_node_new (src);
clutter_paint_node_set_static_name (blit_node, "ShellBlurEffect (blit)");
clutter_paint_node_add_child (background_node, blit_node);
clutter_blit_node_add_blit_rectangle (CLUTTER_BLIT_NODE (blit_node),
transformed_x,
transformed_y,
0, 0,
transformed_width,
transformed_height);
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
}
static gboolean
blur-effect: Fix framebuffer sizes when stage-view scaling is used When blurring only the actor (ACTOR mode), we don't want to apply any scale, it looks fine without using the resource scale and it also seems like `clutter_actor_continue_paint` in `paint_actor_offscreen` only draws an unscaled texture anyway (ie. if the resource scale is 2, only a quarter of the framebuffer is being drawn to). In BACKGROUND mode though, we need to scale the framebuffer using the scale factor of the stage view (ie. the final scale factor for the monitor) because the content of the framebuffer we blit is scaled using that factor. Also, since the framebuffer we blit belongs to a stage view and only includes the contents of this view, we need to adjust the stage-coordinates of the actor to be relative to the stage-view. To make sure we don't have to get the transformed actor size or position multiple times during one paint-run and don't have to carefully floor() or ceil() widths and positions, store the size of the actor (which is also the size of the framebuffer) and its position relative to the stage view inside a ClutterActorBox. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/1000
2020-02-12 22:02:14 +00:00
update_framebuffers (ShellBlurEffect *self,
ClutterPaintContext *paint_context,
ClutterActorBox *source_actor_box)
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
{
gboolean updated = FALSE;
float downscale_factor;
float height = -1;
float width = -1;
blur-effect: Fix framebuffer sizes when stage-view scaling is used When blurring only the actor (ACTOR mode), we don't want to apply any scale, it looks fine without using the resource scale and it also seems like `clutter_actor_continue_paint` in `paint_actor_offscreen` only draws an unscaled texture anyway (ie. if the resource scale is 2, only a quarter of the framebuffer is being drawn to). In BACKGROUND mode though, we need to scale the framebuffer using the scale factor of the stage view (ie. the final scale factor for the monitor) because the content of the framebuffer we blit is scaled using that factor. Also, since the framebuffer we blit belongs to a stage view and only includes the contents of this view, we need to adjust the stage-coordinates of the actor to be relative to the stage-view. To make sure we don't have to get the transformed actor size or position multiple times during one paint-run and don't have to carefully floor() or ceil() widths and positions, store the size of the actor (which is also the size of the framebuffer) and its position relative to the stage view inside a ClutterActorBox. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/1000
2020-02-12 22:02:14 +00:00
clutter_actor_box_get_size (source_actor_box, &width, &height);
blur-effect: Use sigma value instead of blur radius Almost all implementations, including CSS [1] of gaussian blurs use the sigma/standard deviation value as the input parameter, even if they call that value "radius". Since using sigma is more correct mathematically and avoids confusion for people used to other blur implementations, use that parameter here, too. [1] https://www.w3.org/TR/filter-effects-1/#funcdef-filter-blur https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/991
2020-02-10 14:34:57 +00:00
downscale_factor = calculate_downscale_factor (width, height, self->sigma);
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
blur-effect: Use ClutterBlurNode With ClutterBlurNode available, we can remove our own implementation and delegate the blur shader and framebuffers. This simply replaces the pair of layer nodes (vblur and hblur) with a ClutterBlurNode, and removes all dead code. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1528>
2020-12-09 22:20:16 +00:00
updated = update_actor_fbo (self, width, height, downscale_factor) &&
update_brightness_fbo (self, width, height, downscale_factor);
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
if (self->mode == SHELL_BLUR_MODE_BACKGROUND)
updated = updated && update_background_fbo (self, width, height);
self->tex_width = width;
self->tex_height = height;
self->downscale_factor = downscale_factor;
return updated;
}
blur-effect: Port to paint nodes Port the blur effect to the new ClutterEffect.paint_node() vfunc. Update the function names to match what they do, e.g. "apply_blur()" now creates the blur subtree and thus was appropriately renamed to "create_blur_nodes()". There are 3 subtrees that can be generated by the blur effect: 1. Actor mode (full subtree; no cache) Root | | Layer (brightness) | Layer (horizontal blur) | Layer (vertical blur) | Layer (actor) | Transform (downscale) | Actor 2. Actor mode (partial subtree; cached contents) Root | Pipeline (final result) 3. Background mode Root |----------------------- | | Layer (brightness) Actor | Layer (horizontal blur) | Layer (vertical blur) | Layer (background) | Blit Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1339>
2020-06-29 18:35:02 +00:00
static void
add_actor_node (ShellBlurEffect *self,
ClutterPaintNode *node,
int opacity)
{
g_autoptr (ClutterPaintNode) actor_node = NULL;
actor_node = clutter_actor_node_new (self->actor, opacity);
clutter_paint_node_add_child (node, actor_node);
}
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
static void
paint_actor_offscreen (ShellBlurEffect *self,
blur-effect: Port to paint nodes Port the blur effect to the new ClutterEffect.paint_node() vfunc. Update the function names to match what they do, e.g. "apply_blur()" now creates the blur subtree and thus was appropriately renamed to "create_blur_nodes()". There are 3 subtrees that can be generated by the blur effect: 1. Actor mode (full subtree; no cache) Root | | Layer (brightness) | Layer (horizontal blur) | Layer (vertical blur) | Layer (actor) | Transform (downscale) | Actor 2. Actor mode (partial subtree; cached contents) Root | Pipeline (final result) 3. Background mode Root |----------------------- | | Layer (brightness) Actor | Layer (horizontal blur) | Layer (vertical blur) | Layer (background) | Blit Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1339>
2020-06-29 18:35:02 +00:00
ClutterPaintNode *node,
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
ClutterEffectPaintFlags flags)
{
gboolean actor_dirty;
actor_dirty = (flags & CLUTTER_EFFECT_PAINT_ACTOR_DIRTY) != 0;
/* The actor offscreen framebuffer is updated already */
blur-effect: Port to paint nodes Port the blur effect to the new ClutterEffect.paint_node() vfunc. Update the function names to match what they do, e.g. "apply_blur()" now creates the blur subtree and thus was appropriately renamed to "create_blur_nodes()". There are 3 subtrees that can be generated by the blur effect: 1. Actor mode (full subtree; no cache) Root | | Layer (brightness) | Layer (horizontal blur) | Layer (vertical blur) | Layer (actor) | Transform (downscale) | Actor 2. Actor mode (partial subtree; cached contents) Root | Pipeline (final result) 3. Background mode Root |----------------------- | | Layer (brightness) Actor | Layer (horizontal blur) | Layer (vertical blur) | Layer (background) | Blit Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1339>
2020-06-29 18:35:02 +00:00
if (actor_dirty || !(self->cache_flags & ACTOR_PAINTED))
{
g_autoptr (ClutterPaintNode) transform_node = NULL;
g_autoptr (ClutterPaintNode) layer_node = NULL;
graphene_matrix_t transform;
/* Layer node */
layer_node = clutter_layer_node_new_to_framebuffer (self->actor_fb.framebuffer,
self->actor_fb.pipeline);
clutter_paint_node_set_static_name (layer_node, "ShellBlurEffect (actor offscreen)");
clutter_paint_node_add_child (node, layer_node);
clutter_paint_node_add_rectangle (layer_node,
&(ClutterActorBox) {
0.f, 0.f,
self->tex_width / self->downscale_factor,
self->tex_height / self->downscale_factor,
});
/* Transform node */
graphene_matrix_init_scale (&transform,
1.f / self->downscale_factor,
1.f / self->downscale_factor,
1.f);
transform_node = clutter_transform_node_new (&transform);
clutter_paint_node_set_static_name (transform_node, "ShellBlurEffect (downscale)");
clutter_paint_node_add_child (layer_node, transform_node);
/* Actor node */
add_actor_node (self, transform_node, 255);
self->cache_flags |= ACTOR_PAINTED;
}
else
{
g_autoptr (ClutterPaintNode) pipeline_node = NULL;
pipeline_node = clutter_pipeline_node_new (self->actor_fb.pipeline);
clutter_paint_node_set_static_name (pipeline_node,
"ShellBlurEffect (actor texture)");
clutter_paint_node_add_child (node, pipeline_node);
clutter_paint_node_add_rectangle (pipeline_node,
&(ClutterActorBox) {
0.f, 0.f,
self->tex_width / self->downscale_factor,
self->tex_height / self->downscale_factor,
});
}
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
}
static gboolean
needs_repaint (ShellBlurEffect *self,
ClutterEffectPaintFlags flags)
{
gboolean actor_cached;
gboolean blur_cached;
gboolean actor_dirty;
actor_dirty = (flags & CLUTTER_EFFECT_PAINT_ACTOR_DIRTY) != 0;
blur_cached = (self->cache_flags & BLUR_APPLIED) != 0;
actor_cached = (self->cache_flags & ACTOR_PAINTED) != 0;
switch (self->mode)
{
case SHELL_BLUR_MODE_ACTOR:
return actor_dirty || !blur_cached || !actor_cached;
case SHELL_BLUR_MODE_BACKGROUND:
return TRUE;
}
return TRUE;
}
static void
blur-effect: Port to paint nodes Port the blur effect to the new ClutterEffect.paint_node() vfunc. Update the function names to match what they do, e.g. "apply_blur()" now creates the blur subtree and thus was appropriately renamed to "create_blur_nodes()". There are 3 subtrees that can be generated by the blur effect: 1. Actor mode (full subtree; no cache) Root | | Layer (brightness) | Layer (horizontal blur) | Layer (vertical blur) | Layer (actor) | Transform (downscale) | Actor 2. Actor mode (partial subtree; cached contents) Root | Pipeline (final result) 3. Background mode Root |----------------------- | | Layer (brightness) Actor | Layer (horizontal blur) | Layer (vertical blur) | Layer (background) | Blit Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1339>
2020-06-29 18:35:02 +00:00
shell_blur_effect_paint_node (ClutterEffect *effect,
ClutterPaintNode *node,
ClutterPaintContext *paint_context,
ClutterEffectPaintFlags flags)
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
{
ShellBlurEffect *self = SHELL_BLUR_EFFECT (effect);
blur-effect: Only apply paint opacity to actor blur We don't want to apply the opacity of the actor when blurring the background. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/991
2020-02-07 09:21:21 +00:00
uint8_t paint_opacity;
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
blur-effect: Don't check whether effect is enabled when painting A ClutterEffect is being painted as part of the paint cycle of ClutterActor, where _clutter_effect_paint() is called before painting the actual actor. With that, it's impossible that an effect gets painted while it's disabled, so remove the check whether the ClutterActorMeta is enabled before painting. Also if everything works fine in Clutter, the ClutterActorMeta should have an actor set and we've been notified about that actor in shell_blur_effect_set_actor(), so assert that our cached actor is set when painting the effect. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/1000
2020-03-27 22:00:36 +00:00
g_assert (self->actor != NULL);
blur-effect: Use sigma value instead of blur radius Almost all implementations, including CSS [1] of gaussian blurs use the sigma/standard deviation value as the input parameter, even if they call that value "radius". Since using sigma is more correct mathematically and avoids confusion for people used to other blur implementations, use that parameter here, too. [1] https://www.w3.org/TR/filter-effects-1/#funcdef-filter-blur https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/991
2020-02-10 14:34:57 +00:00
if (self->sigma > 0)
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
{
blur-effect: Port to paint nodes Port the blur effect to the new ClutterEffect.paint_node() vfunc. Update the function names to match what they do, e.g. "apply_blur()" now creates the blur subtree and thus was appropriately renamed to "create_blur_nodes()". There are 3 subtrees that can be generated by the blur effect: 1. Actor mode (full subtree; no cache) Root | | Layer (brightness) | Layer (horizontal blur) | Layer (vertical blur) | Layer (actor) | Transform (downscale) | Actor 2. Actor mode (partial subtree; cached contents) Root | Pipeline (final result) 3. Background mode Root |----------------------- | | Layer (brightness) Actor | Layer (horizontal blur) | Layer (vertical blur) | Layer (background) | Blit Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1339>
2020-06-29 18:35:02 +00:00
g_autoptr (ClutterPaintNode) blur_node = NULL;
blur-effect: Use ClutterBlurNode With ClutterBlurNode available, we can remove our own implementation and delegate the blur shader and framebuffers. This simply replaces the pair of layer nodes (vblur and hblur) with a ClutterBlurNode, and removes all dead code. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1528>
2020-12-09 22:20:16 +00:00
switch (self->mode)
{
case SHELL_BLUR_MODE_ACTOR:
paint_opacity = clutter_actor_get_paint_opacity (self->actor);
break;
case SHELL_BLUR_MODE_BACKGROUND:
paint_opacity = 255;
break;
blur-effect: Silence compiler warning Building with `debugoptimized` throws: `'paint_opacity' may be used uninitialized in this function` Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1596>
2021-01-26 20:25:47 +00:00
default:
g_assert_not_reached();
break;
blur-effect: Use ClutterBlurNode With ClutterBlurNode available, we can remove our own implementation and delegate the blur shader and framebuffers. This simply replaces the pair of layer nodes (vblur and hblur) with a ClutterBlurNode, and removes all dead code. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1528>
2020-12-09 22:20:16 +00:00
}
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
if (needs_repaint (self, flags))
{
blur-effect: Fix framebuffer sizes when stage-view scaling is used When blurring only the actor (ACTOR mode), we don't want to apply any scale, it looks fine without using the resource scale and it also seems like `clutter_actor_continue_paint` in `paint_actor_offscreen` only draws an unscaled texture anyway (ie. if the resource scale is 2, only a quarter of the framebuffer is being drawn to). In BACKGROUND mode though, we need to scale the framebuffer using the scale factor of the stage view (ie. the final scale factor for the monitor) because the content of the framebuffer we blit is scaled using that factor. Also, since the framebuffer we blit belongs to a stage view and only includes the contents of this view, we need to adjust the stage-coordinates of the actor to be relative to the stage-view. To make sure we don't have to get the transformed actor size or position multiple times during one paint-run and don't have to carefully floor() or ceil() widths and positions, store the size of the actor (which is also the size of the framebuffer) and its position relative to the stage view inside a ClutterActorBox. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/1000
2020-02-12 22:02:14 +00:00
ClutterActorBox source_actor_box;
update_actor_box (self, paint_context, &source_actor_box);
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
/* Failing to create or update the offscreen framebuffers prevents
* the entire effect to be applied.
*/
blur-effect: Fix framebuffer sizes when stage-view scaling is used When blurring only the actor (ACTOR mode), we don't want to apply any scale, it looks fine without using the resource scale and it also seems like `clutter_actor_continue_paint` in `paint_actor_offscreen` only draws an unscaled texture anyway (ie. if the resource scale is 2, only a quarter of the framebuffer is being drawn to). In BACKGROUND mode though, we need to scale the framebuffer using the scale factor of the stage view (ie. the final scale factor for the monitor) because the content of the framebuffer we blit is scaled using that factor. Also, since the framebuffer we blit belongs to a stage view and only includes the contents of this view, we need to adjust the stage-coordinates of the actor to be relative to the stage-view. To make sure we don't have to get the transformed actor size or position multiple times during one paint-run and don't have to carefully floor() or ceil() widths and positions, store the size of the actor (which is also the size of the framebuffer) and its position relative to the stage view inside a ClutterActorBox. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/1000
2020-02-12 22:02:14 +00:00
if (!update_framebuffers (self, paint_context, &source_actor_box))
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
goto fail;
blur-effect: Use ClutterBlurNode With ClutterBlurNode available, we can remove our own implementation and delegate the blur shader and framebuffers. This simply replaces the pair of layer nodes (vblur and hblur) with a ClutterBlurNode, and removes all dead code. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1528>
2020-12-09 22:20:16 +00:00
blur_node = create_blur_nodes (self, node, paint_opacity);
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
switch (self->mode)
{
case SHELL_BLUR_MODE_ACTOR:
blur-effect: Port to paint nodes Port the blur effect to the new ClutterEffect.paint_node() vfunc. Update the function names to match what they do, e.g. "apply_blur()" now creates the blur subtree and thus was appropriately renamed to "create_blur_nodes()". There are 3 subtrees that can be generated by the blur effect: 1. Actor mode (full subtree; no cache) Root | | Layer (brightness) | Layer (horizontal blur) | Layer (vertical blur) | Layer (actor) | Transform (downscale) | Actor 2. Actor mode (partial subtree; cached contents) Root | Pipeline (final result) 3. Background mode Root |----------------------- | | Layer (brightness) Actor | Layer (horizontal blur) | Layer (vertical blur) | Layer (background) | Blit Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1339>
2020-06-29 18:35:02 +00:00
paint_actor_offscreen (self, blur_node, flags);
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
break;
case SHELL_BLUR_MODE_BACKGROUND:
blur-effect: Port to paint nodes Port the blur effect to the new ClutterEffect.paint_node() vfunc. Update the function names to match what they do, e.g. "apply_blur()" now creates the blur subtree and thus was appropriately renamed to "create_blur_nodes()". There are 3 subtrees that can be generated by the blur effect: 1. Actor mode (full subtree; no cache) Root | | Layer (brightness) | Layer (horizontal blur) | Layer (vertical blur) | Layer (actor) | Transform (downscale) | Actor 2. Actor mode (partial subtree; cached contents) Root | Pipeline (final result) 3. Background mode Root |----------------------- | | Layer (brightness) Actor | Layer (horizontal blur) | Layer (vertical blur) | Layer (background) | Blit Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1339>
2020-06-29 18:35:02 +00:00
paint_background (self, blur_node, paint_context, &source_actor_box);
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
break;
}
}
blur-effect: Port to paint nodes Port the blur effect to the new ClutterEffect.paint_node() vfunc. Update the function names to match what they do, e.g. "apply_blur()" now creates the blur subtree and thus was appropriately renamed to "create_blur_nodes()". There are 3 subtrees that can be generated by the blur effect: 1. Actor mode (full subtree; no cache) Root | | Layer (brightness) | Layer (horizontal blur) | Layer (vertical blur) | Layer (actor) | Transform (downscale) | Actor 2. Actor mode (partial subtree; cached contents) Root | Pipeline (final result) 3. Background mode Root |----------------------- | | Layer (brightness) Actor | Layer (horizontal blur) | Layer (vertical blur) | Layer (background) | Blit Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1339>
2020-06-29 18:35:02 +00:00
else
{
/* Use the cached pipeline if no repaint is needed */
blur-effect: Use ClutterBlurNode With ClutterBlurNode available, we can remove our own implementation and delegate the blur shader and framebuffers. This simply replaces the pair of layer nodes (vblur and hblur) with a ClutterBlurNode, and removes all dead code. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1528>
2020-12-09 22:20:16 +00:00
add_blurred_pipeline (self, node, paint_opacity);
blur-effect: Port to paint nodes Port the blur effect to the new ClutterEffect.paint_node() vfunc. Update the function names to match what they do, e.g. "apply_blur()" now creates the blur subtree and thus was appropriately renamed to "create_blur_nodes()". There are 3 subtrees that can be generated by the blur effect: 1. Actor mode (full subtree; no cache) Root | | Layer (brightness) | Layer (horizontal blur) | Layer (vertical blur) | Layer (actor) | Transform (downscale) | Actor 2. Actor mode (partial subtree; cached contents) Root | Pipeline (final result) 3. Background mode Root |----------------------- | | Layer (brightness) Actor | Layer (horizontal blur) | Layer (vertical blur) | Layer (background) | Blit Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1339>
2020-06-29 18:35:02 +00:00
}
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
/* Background blur needs to paint the actor after painting the blurred
* background.
*/
switch (self->mode)
{
case SHELL_BLUR_MODE_ACTOR:
break;
case SHELL_BLUR_MODE_BACKGROUND:
blur-effect: Port to paint nodes Port the blur effect to the new ClutterEffect.paint_node() vfunc. Update the function names to match what they do, e.g. "apply_blur()" now creates the blur subtree and thus was appropriately renamed to "create_blur_nodes()". There are 3 subtrees that can be generated by the blur effect: 1. Actor mode (full subtree; no cache) Root | | Layer (brightness) | Layer (horizontal blur) | Layer (vertical blur) | Layer (actor) | Transform (downscale) | Actor 2. Actor mode (partial subtree; cached contents) Root | Pipeline (final result) 3. Background mode Root |----------------------- | | Layer (brightness) Actor | Layer (horizontal blur) | Layer (vertical blur) | Layer (background) | Blit Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1339>
2020-06-29 18:35:02 +00:00
add_actor_node (self, node, -1);
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
break;
}
return;
}
fail:
/* When no blur is applied, or the offscreen framebuffers
* couldn't be created, fallback to simply painting the actor.
*/
blur-effect: Port to paint nodes Port the blur effect to the new ClutterEffect.paint_node() vfunc. Update the function names to match what they do, e.g. "apply_blur()" now creates the blur subtree and thus was appropriately renamed to "create_blur_nodes()". There are 3 subtrees that can be generated by the blur effect: 1. Actor mode (full subtree; no cache) Root | | Layer (brightness) | Layer (horizontal blur) | Layer (vertical blur) | Layer (actor) | Transform (downscale) | Actor 2. Actor mode (partial subtree; cached contents) Root | Pipeline (final result) 3. Background mode Root |----------------------- | | Layer (brightness) Actor | Layer (horizontal blur) | Layer (vertical blur) | Layer (background) | Blit Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1339>
2020-06-29 18:35:02 +00:00
add_actor_node (self, node, -1);
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
}
static void
shell_blur_effect_finalize (GObject *object)
{
ShellBlurEffect *self = (ShellBlurEffect *)object;
clear_framebuffer_data (&self->actor_fb);
clear_framebuffer_data (&self->background_fb);
clear_framebuffer_data (&self->brightness_fb);
g_clear_pointer (&self->actor_fb.pipeline, cogl_object_unref);
g_clear_pointer (&self->background_fb.pipeline, cogl_object_unref);
g_clear_pointer (&self->brightness_fb.pipeline, cogl_object_unref);
G_OBJECT_CLASS (shell_blur_effect_parent_class)->finalize (object);
}
static void
shell_blur_effect_get_property (GObject *object,
guint prop_id,
GValue *value,
GParamSpec *pspec)
{
ShellBlurEffect *self = SHELL_BLUR_EFFECT (object);
switch (prop_id)
{
blur-effect: Use sigma value instead of blur radius Almost all implementations, including CSS [1] of gaussian blurs use the sigma/standard deviation value as the input parameter, even if they call that value "radius". Since using sigma is more correct mathematically and avoids confusion for people used to other blur implementations, use that parameter here, too. [1] https://www.w3.org/TR/filter-effects-1/#funcdef-filter-blur https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/991
2020-02-10 14:34:57 +00:00
case PROP_SIGMA:
g_value_set_int (value, self->sigma);
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
break;
case PROP_BRIGHTNESS:
shell/blur-effect: Set float brightness property The brightness property of ShellBlurEffect is of float type, but we are calling g_value_set_int() in the GObject::get_property() handler, which throws warnings when trying to set the property via g_object_set() and family. Use g_value_set_float() instead. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/924
2020-01-09 20:50:11 +00:00
g_value_set_float (value, self->brightness);
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
break;
case PROP_MODE:
g_value_set_enum (value, self->mode);
break;
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
}
}
static void
shell_blur_effect_set_property (GObject *object,
guint prop_id,
const GValue *value,
GParamSpec *pspec)
{
ShellBlurEffect *self = SHELL_BLUR_EFFECT (object);
switch (prop_id)
{
blur-effect: Use sigma value instead of blur radius Almost all implementations, including CSS [1] of gaussian blurs use the sigma/standard deviation value as the input parameter, even if they call that value "radius". Since using sigma is more correct mathematically and avoids confusion for people used to other blur implementations, use that parameter here, too. [1] https://www.w3.org/TR/filter-effects-1/#funcdef-filter-blur https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/991
2020-02-10 14:34:57 +00:00
case PROP_SIGMA:
shell_blur_effect_set_sigma (self, g_value_get_int (value));
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
break;
case PROP_BRIGHTNESS:
shell_blur_effect_set_brightness (self, g_value_get_float (value));
break;
case PROP_MODE:
shell_blur_effect_set_mode (self, g_value_get_enum (value));
break;
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
}
}
static void
shell_blur_effect_class_init (ShellBlurEffectClass *klass)
{
GObjectClass *object_class = G_OBJECT_CLASS (klass);
ClutterActorMetaClass *meta_class = CLUTTER_ACTOR_META_CLASS (klass);
ClutterEffectClass *effect_class = CLUTTER_EFFECT_CLASS (klass);
object_class->finalize = shell_blur_effect_finalize;
object_class->get_property = shell_blur_effect_get_property;
object_class->set_property = shell_blur_effect_set_property;
meta_class->set_actor = shell_blur_effect_set_actor;
blur-effect: Port to paint nodes Port the blur effect to the new ClutterEffect.paint_node() vfunc. Update the function names to match what they do, e.g. "apply_blur()" now creates the blur subtree and thus was appropriately renamed to "create_blur_nodes()". There are 3 subtrees that can be generated by the blur effect: 1. Actor mode (full subtree; no cache) Root | | Layer (brightness) | Layer (horizontal blur) | Layer (vertical blur) | Layer (actor) | Transform (downscale) | Actor 2. Actor mode (partial subtree; cached contents) Root | Pipeline (final result) 3. Background mode Root |----------------------- | | Layer (brightness) Actor | Layer (horizontal blur) | Layer (vertical blur) | Layer (background) | Blit Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1339>
2020-06-29 18:35:02 +00:00
effect_class->paint_node = shell_blur_effect_paint_node;
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
blur-effect: Use sigma value instead of blur radius Almost all implementations, including CSS [1] of gaussian blurs use the sigma/standard deviation value as the input parameter, even if they call that value "radius". Since using sigma is more correct mathematically and avoids confusion for people used to other blur implementations, use that parameter here, too. [1] https://www.w3.org/TR/filter-effects-1/#funcdef-filter-blur https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/991
2020-02-10 14:34:57 +00:00
properties[PROP_SIGMA] =
g_param_spec_int ("sigma",
"Sigma",
"Sigma",
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
0, G_MAXINT, 0,
shell: Specify G_PARAM_EXPLICIT_NOTIFY where appropriate Like we did in ST, opt out of g_object_set()'s implicit change notifications, so that notify is only emitted when a property *actually* changes. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2168>
2022-02-09 17:37:44 +00:00
G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS | G_PARAM_EXPLICIT_NOTIFY);
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
properties[PROP_BRIGHTNESS] =
g_param_spec_float ("brightness",
"Brightness",
"Brightness",
0.f, 1.f, 1.f,
shell: Specify G_PARAM_EXPLICIT_NOTIFY where appropriate Like we did in ST, opt out of g_object_set()'s implicit change notifications, so that notify is only emitted when a property *actually* changes. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2168>
2022-02-09 17:37:44 +00:00
G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS | G_PARAM_EXPLICIT_NOTIFY);
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
properties[PROP_MODE] =
g_param_spec_enum ("mode",
"Blur mode",
"Blur mode",
SHELL_TYPE_BLUR_MODE,
SHELL_BLUR_MODE_ACTOR,
shell: Specify G_PARAM_EXPLICIT_NOTIFY where appropriate Like we did in ST, opt out of g_object_set()'s implicit change notifications, so that notify is only emitted when a property *actually* changes. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2168>
2022-02-09 17:37:44 +00:00
G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS | G_PARAM_EXPLICIT_NOTIFY);
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
g_object_class_install_properties (object_class, N_PROPS, properties);
}
static void
shell_blur_effect_init (ShellBlurEffect *self)
{
self->mode = SHELL_BLUR_MODE_ACTOR;
blur-effect: Use sigma value instead of blur radius Almost all implementations, including CSS [1] of gaussian blurs use the sigma/standard deviation value as the input parameter, even if they call that value "radius". Since using sigma is more correct mathematically and avoids confusion for people used to other blur implementations, use that parameter here, too. [1] https://www.w3.org/TR/filter-effects-1/#funcdef-filter-blur https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/991
2020-02-10 14:34:57 +00:00
self->sigma = 0;
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
self->brightness = 1.f;
self->actor_fb.pipeline = create_base_pipeline ();
self->background_fb.pipeline = create_base_pipeline ();
self->brightness_fb.pipeline = create_brightness_pipeline ();
self->brightness_uniform =
cogl_pipeline_get_uniform_location (self->brightness_fb.pipeline, "brightness");
}
ShellBlurEffect *
shell_blur_effect_new (void)
{
return g_object_new (SHELL_TYPE_BLUR_EFFECT, NULL);
}
int
blur-effect: Use sigma value instead of blur radius Almost all implementations, including CSS [1] of gaussian blurs use the sigma/standard deviation value as the input parameter, even if they call that value "radius". Since using sigma is more correct mathematically and avoids confusion for people used to other blur implementations, use that parameter here, too. [1] https://www.w3.org/TR/filter-effects-1/#funcdef-filter-blur https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/991
2020-02-10 14:34:57 +00:00
shell_blur_effect_get_sigma (ShellBlurEffect *self)
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
{
g_return_val_if_fail (SHELL_IS_BLUR_EFFECT (self), -1);
blur-effect: Use sigma value instead of blur radius Almost all implementations, including CSS [1] of gaussian blurs use the sigma/standard deviation value as the input parameter, even if they call that value "radius". Since using sigma is more correct mathematically and avoids confusion for people used to other blur implementations, use that parameter here, too. [1] https://www.w3.org/TR/filter-effects-1/#funcdef-filter-blur https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/991
2020-02-10 14:34:57 +00:00
return self->sigma;
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
}
void
blur-effect: Use sigma value instead of blur radius Almost all implementations, including CSS [1] of gaussian blurs use the sigma/standard deviation value as the input parameter, even if they call that value "radius". Since using sigma is more correct mathematically and avoids confusion for people used to other blur implementations, use that parameter here, too. [1] https://www.w3.org/TR/filter-effects-1/#funcdef-filter-blur https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/991
2020-02-10 14:34:57 +00:00
shell_blur_effect_set_sigma (ShellBlurEffect *self,
int sigma)
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
{
g_return_if_fail (SHELL_IS_BLUR_EFFECT (self));
blur-effect: Use sigma value instead of blur radius Almost all implementations, including CSS [1] of gaussian blurs use the sigma/standard deviation value as the input parameter, even if they call that value "radius". Since using sigma is more correct mathematically and avoids confusion for people used to other blur implementations, use that parameter here, too. [1] https://www.w3.org/TR/filter-effects-1/#funcdef-filter-blur https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/991
2020-02-10 14:34:57 +00:00
if (self->sigma == sigma)
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
return;
blur-effect: Use sigma value instead of blur radius Almost all implementations, including CSS [1] of gaussian blurs use the sigma/standard deviation value as the input parameter, even if they call that value "radius". Since using sigma is more correct mathematically and avoids confusion for people used to other blur implementations, use that parameter here, too. [1] https://www.w3.org/TR/filter-effects-1/#funcdef-filter-blur https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/991
2020-02-10 14:34:57 +00:00
self->sigma = sigma;
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
self->cache_flags &= ~BLUR_APPLIED;
if (self->actor)
clutter_effect_queue_repaint (CLUTTER_EFFECT (self));
blur-effect: Use sigma value instead of blur radius Almost all implementations, including CSS [1] of gaussian blurs use the sigma/standard deviation value as the input parameter, even if they call that value "radius". Since using sigma is more correct mathematically and avoids confusion for people used to other blur implementations, use that parameter here, too. [1] https://www.w3.org/TR/filter-effects-1/#funcdef-filter-blur https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/991
2020-02-10 14:34:57 +00:00
g_object_notify_by_pspec (G_OBJECT (self), properties[PROP_SIGMA]);
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
}
float
shell_blur_effect_get_brightness (ShellBlurEffect *self)
{
g_return_val_if_fail (SHELL_IS_BLUR_EFFECT (self), FALSE);
return self->brightness;
}
void
shell_blur_effect_set_brightness (ShellBlurEffect *self,
float brightness)
{
g_return_if_fail (SHELL_IS_BLUR_EFFECT (self));
if (self->brightness == brightness)
return;
self->brightness = brightness;
self->cache_flags &= ~BLUR_APPLIED;
if (self->actor)
clutter_effect_queue_repaint (CLUTTER_EFFECT (self));
g_object_notify_by_pspec (G_OBJECT (self), properties[PROP_BRIGHTNESS]);
}
ShellBlurMode
shell_blur_effect_get_mode (ShellBlurEffect *self)
{
g_return_val_if_fail (SHELL_IS_BLUR_EFFECT (self), -1);
return self->mode;
}
void
shell_blur_effect_set_mode (ShellBlurEffect *self,
ShellBlurMode mode)
{
g_return_if_fail (SHELL_IS_BLUR_EFFECT (self));
if (self->mode == mode)
return;
self->mode = mode;
self->cache_flags &= ~BLUR_APPLIED;
switch (mode)
{
case SHELL_BLUR_MODE_ACTOR:
blur-effect: Properly clear background framebuffer We want to completely clear the background framebuffer when switching back to ACTOR mode to make sure the `background_fb.framebuffer` check will fail in `update_background_fbo` when switching to BACKGROUND mode again. Otherwise the checks in `update_background_fbo` will return TRUE and we will keep using the background framebuffer that was created before switchig to ACTOR mode. While at it, also clear the background framebuffer completely when changing the actor to avoid the same issue here. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/1000
2020-02-13 12:08:28 +00:00
clear_framebuffer_data (&self->background_fb);
Introduce ShellBlurEffect This is a moderately fast two-pass gaussian blur implementation. It downscales the framebuffer dynamically before applying the gaussian shader, which cuts down rendering time quite considerably. The blur shader takes 2 uniforms as input: the blur radius; and whether to blur vertically or horizontally. The blur radius is treated as an integer in C land to simplify calculations. The vertical parameter is treated as an integer by the shader simply due to Cogl not having proper boolean support in snippets. At last, brightness is also added to avoid needing to use an extra effect to achieve that. Brightness is applied in a different pipeline than blur, so we can control it more tightly. ShellBlurEffect also implements a "background" mode, where the contents beneath the actor are blurred, but not the actor itself. This mode is performance-heavy. Related: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1848 https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/864
2020-01-07 19:34:03 +00:00
break;
case SHELL_BLUR_MODE_BACKGROUND:
default:
/* Do nothing */
break;
}
if (self->actor)
clutter_effect_queue_repaint (CLUTTER_EFFECT (self));
g_object_notify_by_pspec (G_OBJECT (self), properties[PROP_MODE]);
}
Reference in New Issue Copy Permalink